Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose File class globally #1051

Open
wants to merge 2 commits into
base: feature/add-missing-buffer-apis
Choose a base branch
from

Conversation

appurva21
Copy link
Member

Context

File exists as global only on node v20 or above, while it is available on the Web already.

Changes

We already have File exposed via the buffer module. So to provide consistent behavior across node and web, made File explicitly available using scope libs of Uniscope

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (e5bcec7) to head (83ab9ff).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/add-missing-buffer-apis    #1051   +/-   ##
================================================================
  Coverage                            52.77%   52.77%           
================================================================
  Files                                   12       12           
  Lines                                  612      612           
  Branches                               146      146           
================================================================
  Hits                                   323      323           
  Misses                                 249      249           
  Partials                                40       40           
Flag Coverage Δ
unit 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant