Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fonts with different aspect ratio #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qm3ster
Copy link

@qm3ster qm3ster commented Oct 20, 2021

The PR introduces -a argument that allows pre-scaling the image for non 2:1 fonts.
fixes #64

Interface may be worth bikeshedding, perhaps biasing it to be around 100 and not 1.0 would be useful so integer arguments can be used meaningfully.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@posva
Copy link
Owner

posva commented Oct 21, 2021

Thanks for the PR! I'm quite reluctant about such flag because it's not something intuitive and I don't know how people will guess the aspect ratio of their font. I also don't think people will want to pass an option everytime they use catimg

@qm3ster
Copy link
Author

qm3ster commented Oct 26, 2021

I considered (also) making it an env var, and starting on the path to some standard variable that signifies terminal font aspect, but for the time being people can just alias.
So instead of alias ci="catimg -H50" they'd just do alias ci="catimg -H50 -a1.25" in their dotfiles and be merrily on their way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify image aspect ratio for different terminal fonts
2 participants