[WIP] Multiplicity witgen #1958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
fix-rust-phantom-constr
branch
from
1bbcc9b
to
da9c8dc
Compare
Base automatically changed from
fix-rust-phantom-constr
to
rust-phantom-constr
October 29, 2024 13:09
This was referenced Nov 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
(mostly cherry-picked from #1958) This PR generalizes the multiplicity witness generation we had in `FixedLookup` in the following ways: - Instead of searching for a column of a specific name, takes the witness column from the phantom lookups - As a result, it is also able to handle arbitrarily many lookups - The witness generation should work for all machine types which can be connected via lookups: Fixed lookup, block machines, and secondary VMs. A common use-case that is not yet covered is global range constraints, as they are not represented as machine calls in witness generation. This should be fixed in a follow-up PR. --------- Co-authored-by: chriseth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.