Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Keccak non memory circuit endianness #1960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert Keccak non memory circuit endianness #1960

wants to merge 1 commit into from

Conversation

qwang98
Copy link
Collaborator

@qwang98 qwang98 commented Oct 26, 2024

Was little endian before, now converted to big endian to match with all other machines.

Simple PR.

@leonardoalt
Copy link
Member

since we're changing this, can you also:

  • move the std machine to the small_field directory and change the mod.asm files accordingly
  • rename the test file
  • probably change the filename in pipeline powdr_std tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalt leonardoalt Awaiting requested review from leonardoalt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwang98 @leonardoalt