Add std::math::fp4::square_ext
#1990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Oct 30, 2024
pipeline/tests/powdr_std.rs
Outdated
Comment on lines
444
to
456
| let analyzed = std_analyzed::<Mersenne31Field>(); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::add", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::sub", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::mul", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::square", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::inverse", vec![]); | ||
|
|
||
| let analyzed = std_analyzed::<KoalaBearField>(); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::add", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::sub", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::mul", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::square", vec![]); | ||
| evaluate_function(&analyzed, "std::math::fp4::test::inverse", vec![]); |
There was a problem hiding this comment.
We should be testing with these fields, because we'd also be using Fp4 for those.
Schaeff
previously approved these changes
Oct 31, 2024
chriseth
previously approved these changes
Oct 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
conflicts |
|
Fixed the conflicts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analog of #1989 for Fp2.