Add phantom permutation in std::protocols::permutation::permutation() + change tests
#2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
changed the title
std::protocols::permutation::permutation() + change tests
georgwiese
commented
Nov 11, 2024
Comment on lines
+12
to
+14
| // Currently, witgen fails if the block machine has just enough rows to | ||
| // fit all the blocks, so let's not have a call in the last row. | ||
| col fixed sel = [1, 1, 1, 1, 1, 1, 1, 0]; |
There was a problem hiding this comment.
This can be removed after #2070.
Schaeff
reviewed
Nov 13, 2024
georgwiese
commented
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
std::protocols::permutation::permutation()adds a phantom permutation as well, making witgen work when using it.Also, I changed the tests to be analogous to recent changes to the
lookup_via_challengestest:_extvariant is removed, since we automatically run the extension field variant on Goldilocks (which is tested)