Linker bus support #2073
Open
Linker bus support #2073
+446
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
force-pushed
the
linker-bus-support
branch
from
cb28d27
to
98f0479
Compare
Schaeff
force-pushed
the
linker-bus-support
branch
from
761e6de
to
0c66ecd
Compare
georgwiese
reviewed
Nov 14, 2024
|
|
||
| let to_namespace = to.machine.location.clone().to_string(); | ||
|
|
||
| // the lhs is `instr_flag { operation_id, inputs, outputs }` |
There was a problem hiding this comment.
This comment does not make sense here, does it?
Comment on lines
+181
to
+190
| let lhs = selected( | ||
| combine_flags(from.instr_flag, from.link_flag), | ||
| ArrayLiteral { | ||
| items: op_id | ||
| .chain(from.params.inputs) | ||
| .chain(from.params.outputs) | ||
| .collect(), | ||
| } | ||
| .into(), | ||
| ); |
There was a problem hiding this comment.
It's the same for lookup, could be pulled out of the if block.
Comment on lines
+212
to
+222
| ArrayLiteral { | ||
| items: op_id | ||
| .chain(to.operation.params.inputs_and_outputs().map(|i| { | ||
| index_access( | ||
| namespaced_reference(to_namespace.clone(), &i.name), | ||
| i.index.clone(), | ||
| ) | ||
| })) | ||
| .collect(), | ||
| } | ||
| .into(), |
There was a problem hiding this comment.
This would also be the same for the lookup.
| @@ -154,6 +155,10 @@ enum Commands { | |||
| #[arg(long)] | |||
| backend_options: Option<String>, | |||
|
|
|||
| /// Linker mode, deciding how to reduce links to constraints. | |||
| #[arg(long)] | |||
| linker_mode: Option<LinkerMode>, | |||
There was a problem hiding this comment.
Suggested change
| linker_mode: Option<LinkerMode>, | |
| #[arg(value_parser = clap_enum_variants!(LinkerMode))] | |
| linker_mode: Option<LinkerMode>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the linker to enable creating statements both in the source and in the target of a link. Instead of creating a vector of statements, we create a (name=>namespace) map.
The linker mode is exposed in the CLI, and currently defaults to the native lookup/permutation statements.
Bus linking can be activated the following way:
cargo run pil test_data/asm/vm_to_block_unique_interface.asm --force --linker-mode busTODO: