Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt: equal-constrained witness columns removal #2086

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Opt: equal-constrained witness columns removal #2086

wants to merge 12 commits into from

Conversation

gzanitti
Copy link
Collaborator

Resolves #2081

@chriseth
Copy link
Member

Nice! Did you try what the result on test_data/std/poseidon_gl_test.asm is?

chriseth
chriseth reviewed Nov 14, 2024
View reviewed changes
pilopt/src/lib.rs Outdated Show resolved Hide resolved
@gzanitti
Copy link
Collaborator Author

Nice! Did you try what the result on test_data/std/poseidon_gl_test.asm is?

Yes, it went from Removed 164 witness and 154 fixed columns. Total count now: 99 witness and 50 fixed columns. to Removed 175 witness and 154 fixed columns. Total count now: 88 witness and 50 fixed columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizer should remove equal-constrained witness columns.
2 participants
@gzanitti @chriseth