Witgen: Match machine calls by Bus ID (2) #2488
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwang98
reviewed
Feb 26, 2025
| .flat_map(|(index, m)| { | ||
| m.borrow() | ||
| .identity_ids() | ||
| .into_iter() | ||
| .map(move |id| (id, index)) | ||
| }) | ||
| .flat_map(|(index, m)| m.borrow().bus_ids().into_iter().map(move |id| (id, index))) |
There was a problem hiding this comment.
Looks like these are the key changes of this PR. We now use bus_ids instead of identity_ids. However, I wonder for cases that don't use the bus linker mode, such as native permutation and lookups, then we won't have bus_ids? Then how are machine calls linked?
qwang98
reviewed
Feb 26, 2025
Comment on lines
-91
to
+88
| for connection in &all_connections { | ||
| for bus_receive in self.fixed.bus_receives.values() { | ||
| // If the RHS only consists of fixed columns, record the connection and continue. | ||
| if FixedLookup::is_responsible(connection) { | ||
| assert!(fixed_lookup_connections | ||
| .insert(connection.id, *connection) | ||
| if FixedLookup::is_responsible(bus_receive) { | ||
| assert!(fixed_lookup_receives | ||
| .insert(bus_receive.bus_id, *bus_receive) |
There was a problem hiding this comment.
What's the key reason for replacing connection with bus_receives? Where's the key logic that matches bus sends with bus receives (via id)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.