-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse handle_query prover functions. #2503
base: main
Are you sure you want to change the base?
Conversation
e58288a
to
1e27b18
Compare
1e27b18
to
7ccd1b4
Compare
@@ -36,12 +38,23 @@ pub enum ProverFunctionComputation<'a> { | |||
/// The expression `f` in `query |i| std::prover::compute_from(Y, i, [X, ...], f)`, | |||
/// where f: (fe[] -> fe) | |||
ComputeFrom(&'a Expression), | |||
/// Represents a call to `handle_query` (see `try_decode_handle_query`), where the | |||
/// keys are the pc values (the first input column). The two two arguments to both input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"two two arguments"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is missing some context here (not sure what "two arguments" or "input columns" are referring to)... maybe it should be elsewhere or have a bit more context?
{ | ||
Ok(provide_if_unknown) | ||
let results = [ | ||
try_decode_provide_if_unknown(index, function, try_symbol_by_name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor, but this way its always evaluating all three, instead of stopping on the first success... if the functions have the same signature, maybe its possible to do something like [try_func1, try_func2, try_func3].iter().map(|f| f(...))
?
Parses query / prover functions of the form
i.e. the ones used for "free input" columns.