Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SingleStore docs #23590

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Updated SingleStore docs #23590

merged 4 commits into from
Oct 10, 2024

Conversation

oyeliseiev-ua
Copy link
Contributor

Description

Updated SingleStore docs

Motivation and Context

Wrong description

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@oyeliseiev-ua oyeliseiev-ua changed the title Update SingleStore docs Updated SingleStore docs Sep 5, 2024
@github-actions github-actions bot added the docs label Sep 5, 2024
steveburnett
steveburnett requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! A minor nit about the link, looks good otherwise.

presto-docs/src/main/sphinx/connector/singlestore.rst Outdated Show resolved Hide resolved
@steveburnett
Copy link
Contributor

@oyeliseiev-ua, are you able to continue working on this?

@oyeliseiev-ua
Copy link
Contributor Author

@steveburnett yes, committed your suggestion. Thank you.

steveburnett
steveburnett requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Two minor nits, and looks good otherwise.

presto-docs/src/main/sphinx/connector/singlestore.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/singlestore.rst Outdated Show resolved Hide resolved
steveburnett
steveburnett approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, everything looks good. Thanks for the quick update!

@steveburnett steveburnett merged commit 8ce4ccd into prestodb:master Oct 10, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveburnett steveburnett steveburnett approved these changes

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
docs
Projects
Presto Documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyeliseiev-ua @steveburnett