Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Switch to HEAD method for exchange get size call #23630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdcmeehan
Copy link
Contributor

Warning: depends on #23576

Description

Removed usage of the X-Presto-Get-Data-Size header in Prestissimo.

Motivation and Context

#21926

Impact

Use HEAD on /v1/{taskId}/results/{bufferId} to retrieve exchange buffer information without exchanging data.

Test Plan

Prestissimo tests that include an exchange will be tested here.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdcmeehan

@amitkdutta amitkdutta self-assigned this Sep 19, 2024
@amitkdutta
Copy link
Contributor

Thanks @tdcmeehan. Lets merge it.

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So once its merged, we need to include this PR and #23576 both in the subsequent releases. Let me know if thats correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants