remove assignment and bitfield alignment #355
Merged
+26,036
−26,037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienntindall
requested changes
Nov 12, 2024
Comment on lines
+438
to
+442
| EGG = 0, | ||
| EVENT = 0, | ||
| HATCHED = 0, | ||
| PAL_PARK = 0, | ||
| TALL_GRASS = 2, |
There was a problem hiding this comment.
Any way that we can keep the alignment on enum/do it manually or will clang-format override them all the time?
There was a problem hiding this comment.
it's a WIP issue in clang-format, if someone was to implement it, we could use clang-format 20 git to have it
the alternative is to go to each enum and manually align it with a clang-format off but that'd be a lot of work
adrienntindall
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as agreed in #gen-4-alignment