Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move components from staff CSS modules feature flag to ga #5710

Merged
merged 19 commits into from
Feb 21, 2025

Conversation

jonrohan
Copy link
Member

Changelog

New

Changed

  • Moving Autocomplete to CSS modules ga flag
  • Moving ConfirmationDialog to primer_react_css_modules_ga feature flag
  • Moving DataTable to primer_react_css_modules_ga feature flag
  • Moving UnderlinePanels to primer_react_css_modules_ga feature flag
  • Moving InlineMessage to primer_react_css_modules_ga feature flag
  • Moving KeybindingHint to primer_react_css_modules_ga feature flag
  • Moving NavList to primer_react_css_modules_ga feature flag
  • Moving Overlay to primer_react_css_modules_ga feature flag
  • Moving PageHeader to primer_react_css_modules_ga feature flag
  • Moving PageLayout to primer_react_css_modules_ga feature flag
  • Moving Pagination to primer_react_css_modules_ga feature flag
  • Moving SegmentedControl to primer_react_css_modules_ga feature flag
  • Moving SelectPanel to primer_react_css_modules_ga feature flag
  • Moving SubNav to primer_react_css_modules_ga feature flag
  • Moving Token to primer_react_css_modules_ga feature flag
  • Moving Tooltip to primer_react_css_modules_ga feature flag
  • Moving BaseStyles to primer_react_css_modules_ga feature flag
  • Moving SideNav to primer_react_css_modules_ga feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

This shouldn't need any integration testing, prod will remain unchanged, only more eyes on these components.

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner February 19, 2025 22:25
@jonrohan jonrohan requested a review from langermank February 19, 2025 22:25
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 29cddd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan requested a review from joshblack February 19, 2025 22:25
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 19, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.77 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 106.17 KB (+0.11% 🔺)

@jonrohan jonrohan enabled auto-merge February 19, 2025 22:39
@jonrohan jonrohan added this pull request to the merge queue Feb 19, 2025
@joshblack joshblack removed this pull request from the merge queue due to a manual request Feb 19, 2025
@joshblack joshblack enabled auto-merge February 19, 2025 23:34
@amirdjbdj3873
Copy link

@nami1278

@amirdjbdj3873
Copy link

کمپپهممثمثمثوثمثم

@joshblack joshblack added this pull request to the merge queue Feb 21, 2025
@joshblack joshblack removed this pull request from the merge queue due to a manual request Feb 21, 2025
@jonrohan jonrohan added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit b1cdc63 Feb 21, 2025
48 checks passed
@jonrohan jonrohan deleted the move_staff_components_flag_to_ga branch February 21, 2025 18:47
@primer primer bot mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants