Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use React 18 and 19 compatible types #104

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR updates @prismicio/next to be compatible with React 18 and 19 TypeScript types.

React 19 requires changing JSX.Element to React.JSX.Element (see the React 19 release notes). The change is compatible with React 18's TypeScript types.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@angeloashmore angeloashmore merged commit 18b6be0 into main Jan 29, 2025
11 checks passed
@angeloashmore angeloashmore deleted the aa/react-19-jsx-fix branch January 29, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant