Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Cargo Clippy to avoid the gen reserved keyword #181

Closed
wants to merge 1 commit into from
Closed

fix: Use Cargo Clippy to avoid the gen reserved keyword #181

wants to merge 1 commit into from

Conversation

heeckhau
Copy link
Collaborator

@heeckhau heeckhau commented Sep 5, 2024

RUSTFLAGS="-D keyword_idents_2024" cargo clippy --fix fixes #180

@heeckhau
fix: Use Cargo Clippy to avoid the gen reserved keyword
5ca9929 
RUSTFLAGS="-D keyword_idents_2024" cargo clippy --fix
fixes #180
@heeckhau heeckhau linked an issue Sep 5, 2024 that may be closed by this pull request
Replace usage of gen prior to next Rust edition #180
Closed
@sinui0
Copy link
Collaborator

sinui0 commented Sep 5, 2024

This is a fix, but I would rather rename instead of r#. rand will be changing gen to random in the next release. We may want to rename to Garbler

@sinui0
Copy link
Collaborator

sinui0 commented Feb 14, 2025

Closing, I would prefer we avoid the r# solution

@sinui0 sinui0 closed this Feb 14, 2025
@sinui0 sinui0 deleted the 180-replace-usage-of-gen-prior-to-next-rust-edition branch February 14, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinui0 sinui0 Awaiting requested review from sinui0

@themighty1 themighty1 Awaiting requested review from themighty1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usage of gen prior to next Rust edition
2 participants
@heeckhau @sinui0