Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the API macro to accept all arguments #6

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

Yatekii
Copy link
Member

@Yatekii Yatekii commented Dec 10, 2023

I fixed most points. I am not sure how to fix:

  • In memory.x, the data, sdata, and bss sections are duplicated and should be removed from PrgCode. Maybe @Tiwalun knows. I feel like all might be needed?
  • There is one quirky bit in the scripts that expect the PrgData to be marked RW, so I needed to a dummy global variable. I don't know if there is another way to force the section to be read-write. I am not sure it has to be marked RW? Never had issues with any of the algos and we don't check that. Also, I would rather forego the dummy.

cc @mbossard, @Tiwalun

@mbrossard
Copy link

I am basing the first comment on https://github.com/pyocd/FlashAlgo/blob/main/source/FlashAlgo.ld

I found a cleaner way to fix the second issue:

core::arch::global_asm!(".section .PrgData, \"aw\"");

@Yatekii Yatekii merged commit 8af3d68 into master Jan 28, 2024
1 check passed
@Yatekii Yatekii deleted the task/extend-api branch January 28, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants