Extend the API macro to accept all arguments #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed most points. I am not sure how to fix:
In memory.x, the data, sdata, and bss sections are duplicated and should be removed from PrgCode.
Maybe @Tiwalun knows. I feel like all might be needed?There is one quirky bit in the scripts that expect the PrgData to be marked RW, so I needed to a dummy global variable. I don't know if there is another way to force the section to be read-write.
I am not sure it has to be marked RW? Never had issues with any of the algos and we don't check that. Also, I would rather forego the dummy.cc @mbossard, @Tiwalun