Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde alias for FormatOptions::binary_format #2263

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add serde alias for FormatOptions::binary_format #2263

merged 2 commits into from
Mar 6, 2024

Conversation

noppej
Copy link
Contributor

@noppej noppej commented Mar 6, 2024

#2240 introduces a change that negatively impacts the DAP clients like the VSCode extension. This PR introduces a temporary fix to ensure those clients can continue to work without requiring an immediate release.

Once we have released the current master branch, we can release probe-rs/vscode#86, and then remove this alias.

@noppej noppej requested a review from bugadani March 6, 2024 19:49
@noppej noppej added the changelog:skip This PR does not require a changelog entry on release label Mar 6, 2024
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@noppej noppej added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit b6f1f1e Mar 6, 2024
18 checks passed
@noppej noppej deleted the add_alias branch March 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip This PR does not require a changelog entry on release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants