-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update or remove(if appropriate) incorrect defaults. #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bugadani Is this a work in progress? I cannot see where in the currently committed code the defaults have been changed.
Also, I wonder if removing the defaults might do more harm than good? Would it not be a better user experience to harmonize the defaults with the probe-rs
implementation. That way, launch.json
will hint at the correct default.
Finally, if we change the schema, it would be really nice if we can cleanup the appropriate references in the docs. If that is too much to ask, please open an issue against https://github.com/probe-rs/webpage, and I'd be happy to add it to my list.
He just synchronized the VSCode config schema with the actual default values we use :) |
Github is so strange. I looked at the changes just before typing that comment, and there were no changes to the default in I looked again, and they are all there. |
The code changes looks fine, and I'm happy to approve. However, if we release this PR, the docs will contradict the product. |
Tbh, this is the docs. If you configure stuff you look at the autocompletion of vscode :) |
I'd be OK if we decide to rip relevant pieces where contradictions exist, from the docs? It makes more sense now that intellisense actually works (courtesy of @bugadani efforts |
For some cases the defaults made no sense to me. For example, the SVD path - if it's not set, probe-rs just doesn't use it instead of defaulting to whatever the extension specified. Program binary is required, so a default again makes little sense to me. Forgot to sack npx, sorry about that |
Keeping the minor version in synch with probe-rs. Also, this will trigger a publish to the marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bugadani ... having "working" intellisense, that gives the "correct" guidance is valuable for usability.
Closes #75 because the root cause of it was an incorrect assumption made from incorrect defaults.