Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DebugConfigurationProvider for configuration defaults #84

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add DebugConfigurationProvider for configuration defaults #84

merged 3 commits into from
Feb 6, 2024

Conversation

noppej
Copy link
Contributor

@noppej noppej commented Feb 6, 2024

This fixes an issue where updating the cwd configuration in extension.ts file is not propagated to the probe-rs dap-server.

@noppej
Copy link
Contributor Author

noppej commented Feb 6, 2024

@bugadani This should fix this issue ... I'd appreciate if you can confirm when you have a free moment.

bugadani
bugadani approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to do the job, thank you very much!

@noppej noppej merged commit c14d5c7 into master Feb 6, 2024
3 checks passed
@noppej noppej deleted the fix_cwd_default branch February 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noppej @bugadani