Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added multi-threading to the update script #14

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Added multi-threading to the update script #14

merged 5 commits into from
Dec 16, 2024

Conversation

Stefterv
Copy link
Collaborator

@Stefterv Stefterv commented Dec 13, 2024 •
edited
Loading

Now it runs in less than 2 mins and spikes to 100% cpu usage on my MacBook

Fixes #13

mingness
mingness requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@mingness mingness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Just need to make sure the updated info is written to the database file.

@Stefterv Stefterv requested a review from mingness December 16, 2024 18:34
mingness
mingness approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@mingness mingness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉
I do need to fix something else though - will create a PR for it.

@Stefterv Stefterv merged commit 4794110 into main Dec 16, 2024
1 check failed
@Stefterv Stefterv deleted the multithreaded branch December 16, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingness mingness mingness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub action takes 30 minutes because of sequential execution
2 participants
@Stefterv @mingness