Patch for keyPressed true with no keys pressed after specific sequence of SHIFT or CTRL
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that earlier we were using a hash for registering keys. For example, when someone pressed Ctrl and then A, the combination Ctrl+A got registered, and when they released Ctrl and then A, the Ctrl+A combination remained registered because it had a specific hash that was not released upon releasing both keys. That is why I removed the hash and am now directly registering the key.
However, I'm not sure why we were using a hash in the first place. Is there any specific reason? If yes, then I can change this approach.
Fixes #779