Escape notepad++ default installation path #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben
reviewed
Aug 12, 2024
| @@ -59,7 +59,7 @@ Accompanying the configuration instructions in <<ch01-getting-started#_editor>>, | |||
| |Kate (Linux) |`git config --global core.editor "kate --block"` | |||
| |nano |`git config --global core.editor "nano -w"` | |||
| |Notepad (Windows 64-bit) |`git config core.editor notepad` | |||
| |Notepad++ (Windows 64-bit) |`git config --global core.editor "'C:\Program Files\Notepad++\notepad++.exe' -multiInst -notabbar -nosession -noPlugin"` (Also see note below) | |||
| |Notepad++ (Windows 64-bit) |`git config --global core.editor "'C:\Program Files\Notepad+\+\notepad++.exe' -multiInst -notabbar -nosession -noPlugin"` (Also see note below) | |||
There was a problem hiding this comment.
Interesting. Only the second + needs to be escaped? The other three are fine?
There was a problem hiding this comment.
I believe escaping any one of the four + that surrounds \notepad should stop it from being considered as an enclosing pair of double pluses.
When I experimented with escaping more than one, the literal backslashes appeared in the output, possibly because by that point there was no special meaning to actually escape and they were interpreted literally.
ben
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
It appears that the pair of "++" in the Notepad++ path may be interpreted as an inline passthrough by Asciidoctor. The double pluses are omitted in the rendered text (both on git-scm.com and the .pdf in the latest release.) The resulting command is incorrect if copied and pasted into the terminal, which is exactly what I had done when I noticed the problem.
If GitHub's web editor is rendering my change correctly, a single backslash in the first pair of double pluses is enough to fix the issue. After reading the contributing guidelines, I figured this is a minor enough correction that I did not need to open an issue first, but I have not contributed before. Constructive criticism welcomed. Thank you for your time.