Deprecate the start_over partial. Render the component instead #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
added a commit
that referenced
this pull request
Sep 23, 2024
Just render the component directly. See #3327 for deprecation in 8.x branch
jcoyne
added a commit
that referenced
this pull request
Sep 23, 2024
Just render the component directly. See #3327 for deprecation in 8.x branch
jcoyne
force-pushed
the
deprecate_start_over_partial
branch
from
2eda746
to
fd421f2
Compare
jcoyne
force-pushed
the
deprecate_start_over_partial
branch
from
fd421f2
to
29ec341
Compare
|
Unlike #3333, I think this one is ok, right? |
|
Yes. I think the local in the partial is safer. |
jcoyne
added a commit
that referenced
this pull request
Oct 24, 2024
Just render the component directly. See #3327 for deprecation in 8.x branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.