Program connected routes for borrowed VXLAN tunnel addresses #9662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
coutinhop
approved these changes
Jan 2, 2025
caseydavenport
changed the title
Add new Borrowed flag to protobuf so dataplane can tell which routes are borrowed.
caseydavenport
force-pushed
the
casey-vxlan-borrow
branch
from
ec8dbb8 to
56f62ef
Compare
fasaxc
reviewed
Jan 3, 2025
3 tasks
|
@fasaxc I'm looking into it... It doesn't look trivial based on my reading. The FV tests rely pretty heavily on algorithmic IP allocation - both for assigning VXLAN tunnel IPs to nodes, and then workload IPs. It makes it tricky to carve out exceptions. I might still be able to thread something through... |
|
I'm going to merge this for now, but raise a story into the sprint to keep looking at FV tests. So far, it's proven rather challenging to make it work and I think it might require a larger change to the way we configure VXLAN FV tests in general, so would like to bank this one as is. |
caseydavenport
added
cherry-pick-completed
caseydavenport
added a commit
to caseydavenport/calico
that referenced
this pull request
Jan 8, 2025
…-borrow Program connected routes for borrowed VXLAN tunnel addresses
3 tasks
caseydavenport
added a commit
that referenced
this pull request
Jan 8, 2025
Program connected routes for borrowed VXLAN tunnel addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Program routes to VXLAN tunnel IP addresses. This fixes an issue where nodes with borrowed IPs had broken connectivity. Previoiusly, we were relying on the route for the block to provide connectivity to the tunnel, but this isn't always the case.
Related issues/PRs
Fixes #6160
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.