Deprecate --disable-default-metrics and improve deprecation #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--disable-default-metrics was used to disable all built in collectors and only run queries from the queries.yaml file which is no longer supported. Improver verbiage in queries.yaml file pointing to replacement collector for custom queries. Signed-off-by: Joe Adams <[email protected]>
|
I'm actually trying to keep this, but we're going to move it to the exporter-toolkit package. This way the use is consistent across exporters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--disable-default-metrics was used to disable all built in collectors and only run queries from the queries.yaml file which is no longer supported. Improver verbiage in queries.yaml file pointing to replacement collector for custom queries.