Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing broken link pointing to remote_write_spec.md #2568

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fixing broken link pointing to remote_write_spec.md #2568

merged 1 commit into from
Feb 20, 2025

Conversation

lhajouji
Copy link
Contributor

Fixes #2567

machine424
machine424 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in [1.0 Remote-Write specification](/docs/specs/remote_write_spec/#protocol) I assume that the links aren't meant to work for markdown.
Not sure if there is an easy way to have them work for both.

Thanks for this.

@machine424 machine424 merged commit ed38395 into prometheus:main Feb 20, 2025
1 check passed
@machine424
Copy link
Member

I see another broken one at The prometheus.WriteRequest introduced in... on the same page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 machine424 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link in "Prometheus Remote-Write 2.0 [EXPERIMENTAL]"
2 participants
@lhajouji @machine424