Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prombench: add Kubernetes resource requests #797

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

bboreham
Copy link
Member

Best to tell the system what is needed.

Specific levels based on observing at GKE, after changing scraping to 15s per #796.

I left some containers un-set, e.g. the init container that builds Prometheus.

Best to tell the system what is needed.

Specific levels based on observing at GKE.

Signed-off-by: Bryan Boreham <[email protected]>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun kakkoyun merged commit f5b2ae9 into master Nov 28, 2024
4 checks passed
@kakkoyun kakkoyun deleted the add-requests branch November 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants