Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(secrets): Add TelegramBotToken detector #5321

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Oct 8, 2024

Context

The issue related with the TelegramBotToken detector in https://github.com/Yelp/detect-secrets is now fixed since Yelp/detect-secrets#878 got merged.

Also fixes #4893

Description

Enable the TelegramBotToken plugin in detect-secrets.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the backport-to-v4.4 Backport PR to the v4.4 branch label Oct 8, 2024
@jfagoagas jfagoagas requested review from a team as code owners October 8, 2024 07:01
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (3950d7e) to head (9bffebe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5321      +/-   ##
==========================================
+ Coverage   89.29%   89.34%   +0.05%     
==========================================
  Files        1013     1013              
  Lines       31113    31113              
==========================================
+ Hits        27781    27798      +17     
+ Misses       3332     3315      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔝

@MrCloudSec MrCloudSec merged commit 5bf8536 into master Oct 8, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the add-telegram-bot-token branch October 8, 2024 12:09
prowler-bot pushed a commit that referenced this pull request Oct 8, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.4 Backport PR to the v4.4 branch was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve detect-secrets engine: configuration + plugins
4 participants