Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature arc #24

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature arc #24

wants to merge 4 commits into from

Conversation

psineur
Copy link
Owner

@psineur psineur commented Feb 1, 2013

Subj, originally from #21
If ok - will close #23

psineur added a commit that referenced this pull request Apr 1, 2013
@psineur
Merge branch 'feature-cocoapods-noarc' Closes #25, but not #24
f0c3fc1 
Analyzer issues (leaks) in #24 - excluded ARC commits
@psineur
Copy link
Owner Author

psineur commented Apr 1, 2013

Leak:
Screen Shot 2013-04-01 at 0 54 17

I don't think that ARC support is very important here - as you can see diff is pretty small.
But I think that this can increase popularity of the AMC.

Proposed solution:

  1. Support both ARC/NOARC with preprocessor macros
  2. Make analyzer happy

Anyone who is interested in this - please comment, your opinion is important

@psineur
Copy link
Owner Author

psineur commented Apr 1, 2013

Note to self: don't forget #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psineur @jwilling