Skip to content

Commit

Permalink
Feature/refactor stuff (#1087)
Browse files Browse the repository at this point in the history
* REFACTOR

* FIX

* FIX default import

* FIX stuff
  • Loading branch information
pubkey authored Dec 28, 2022
1 parent 73b44db commit 6360c4f
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 29 deletions.
12 changes: 8 additions & 4 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,31 @@ const plugins = [
'@babel/transform-literals',
'@babel/transform-function-name',
'@babel/transform-arrow-functions',
'@babel/transform-block-scoped-functions', ['@babel/transform-classes', {
'@babel/transform-block-scoped-functions',
['@babel/transform-classes', {
'loose': true
}],
'@babel/transform-object-super',
'@babel/transform-shorthand-properties', ['@babel/transform-computed-properties', {
'@babel/transform-shorthand-properties',
['@babel/transform-computed-properties', {
'loose': true
}],
['@babel/transform-for-of', {
'loose': true
}],
'@babel/transform-sticky-regex',
'@babel/transform-unicode-regex',
'@babel/transform-parameters', ['@babel/transform-destructuring', {
'@babel/transform-parameters',
['@babel/transform-destructuring', {
'loose': true
}],
'@babel/transform-block-scoping',
'@babel/plugin-proposal-object-rest-spread',
'@babel/plugin-transform-member-expression-literals',
'@babel/transform-property-literals',
'@babel/transform-async-to-generator',
'@babel/transform-regenerator', ['@babel/transform-runtime', {
'@babel/transform-regenerator',
['@babel/transform-runtime', {
'regenerator': true
}]
];
Expand Down
30 changes: 15 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "broadcast-channel",
"version": "4.18.1",
"description": "A BroadcastChannel that works in New Browsers, Old Browsers, WebWorkers and NodeJs",
"description": "A BroadcastChannel that works in New Browsers, Old Browsers, WebWorkers and NodeJs and iframes",
"exports": {
".": {
"node": {
Expand Down Expand Up @@ -85,38 +85,38 @@
"lint"
],
"dependencies": {
"@babel/runtime": "^7.16.0",
"@babel/runtime": "7.20.7",
"oblivious-set": "1.1.1",
"p-queue": "6.6.2",
"rimraf": "3.0.2",
"unload": "2.4.0"
},
"devDependencies": {
"@babel/cli": "7.20.7",
"@babel/core": "7.20.7",
"@babel/plugin-proposal-object-rest-spread": "7.20.7",
"@babel/cli": "7.19.3",
"@babel/core": "7.19.6",
"@babel/plugin-proposal-object-rest-spread": "7.19.4",
"@babel/plugin-transform-member-expression-literals": "7.18.6",
"@babel/plugin-transform-property-literals": "7.18.6",
"@babel/plugin-transform-runtime": "7.19.6",
"@babel/polyfill": "7.12.1",
"@babel/preset-env": "7.20.2",
"@babel/types": "7.20.7",
"@babel/preset-env": "7.19.4",
"@babel/types": "7.20.0",
"@rollup/plugin-node-resolve": "15.0.1",
"@types/core-js": "2.5.5",
"assert": "2.0.0",
"async-test-util": "2.0.0",
"browserify": "17.0.0",
"child-process-promise": "2.2.1",
"clone": "2.1.2",
"concurrently": "7.6.0",
"concurrently": "7.5.0",
"convert-hrtime": "5.0.0",
"copyfiles": "2.4.1",
"cross-env": "7.0.3",
"detect-node": "2.1.0",
"eslint": "8.30.0",
"eslint": "8.26.0",
"gzip-size-cli": "5.1.0",
"http-server": "14.1.1",
"jest": "29.3.1",
"jest": "29.2.2",
"karma": "6.4.1",
"karma-babel-preprocessor": "8.0.2",
"karma-browserify": "8.1.0",
Expand All @@ -130,18 +130,18 @@
"karma-mocha": "2.0.1",
"karma-opera-launcher": "1.0.0",
"karma-safari-launcher": "1.0.0",
"mocha": "10.2.0",
"mocha": "10.1.0",
"pre-commit": "1.2.2",
"random-int": "3.0.0",
"random-token": "0.0.8",
"rollup": "2.79.1",
"rollup-plugin-terser": "7.0.2",
"testcafe": "2.1.0",
"testcafe": "2.0.2",
"ts-node": "10.9.1",
"typescript": "4.9.4",
"typescript": "4.8.4",
"uglify-js": "3.17.4",
"watchify": "4.0.0",
"webpack": "5.75.0",
"webpack-cli": "5.0.1"
"webpack": "5.74.0",
"webpack-cli": "4.10.0"
}
}
10 changes: 5 additions & 5 deletions src/method-chooser.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import NativeMethod from './methods/native.js';
import IndexedDbMethod from './methods/indexed-db.js';
import LocalstorageMethod from './methods/localstorage.js';
import SimulateMethod from './methods/simulate.js';
import { NativeMethod } from './methods/native.js';
import { IndexedDBMethod } from './methods/indexed-db.js';
import { LocalstorageMethod } from './methods/localstorage.js';
import { SimulateMethod } from './methods/simulate.js';
// the line below will be removed from es5/browser builds
import * as NodeMethod from './methods/node.js';

// order is important
const METHODS = [
NativeMethod, // fastest
IndexedDbMethod,
IndexedDBMethod,
LocalstorageMethod
];

Expand Down
2 changes: 1 addition & 1 deletion src/methods/cookies.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**
* if you really need this method,
* implement it
* implement it!
*/
2 changes: 1 addition & 1 deletion src/methods/indexed-db.js
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ export function averageResponseTime(options) {
return options.idb.fallbackInterval * 2;
}

export default {
export const IndexedDBMethod = {
create,
close,
onMessage,
Expand Down
2 changes: 1 addition & 1 deletion src/methods/localstorage.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export function averageResponseTime() {
return defaultTime;
}

export default {
export const LocalstorageMethod = {
create,
close,
onMessage,
Expand Down
2 changes: 1 addition & 1 deletion src/methods/native.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function averageResponseTime() {
return 150;
}

export default {
export const NativeMethod = {
create,
close,
onMessage,
Expand Down
2 changes: 1 addition & 1 deletion src/methods/simulate.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function averageResponseTime() {
return 5;
}

export default {
export const SimulateMethod = {
create,
close,
onMessage,
Expand Down

0 comments on commit 6360c4f

Please sign in to comment.