Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply reduces the argument type requirements of
getOrder(order: Order)
from an object of typeOrder
, to simply an object containing a URL (effectivelyPick<Order, 'url'>
). Only the Order URL is needed to retrieve an Order and re-create object, and that's howapi
usesgetOrder
anyway. Sinceapi
isn't exposed to consumers ofacme-client
, I propose this modest change.Here's an example use-case:
Unfortunately, TypeScript will warn the following:
Looking at the type definition of the
acme-client
order, I see that it actually extends therfc8555.Order
definition:And creating a
rfc8555.Order
just to satisfy the function argument type requirements is onerous:Thanks for your consideration!