Implementing support for ingesting DSpace resources using Rake tasks #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
force-pushed
the
jrgriffiniii-dspace-ingest-rake
branch
from
3bce0c6 to
a839170
Compare
tpendragon
requested changes
Mar 19, 2025
app/jobs/ingest_dspace_asset_job.rb
Outdated
| # frozen_string_literal: true | ||
| class IngestDspaceAssetJob < ApplicationJob | ||
| # DataSpace assets are treated as ScannedResources | ||
| def perform(directory:, property: nil, change_set_param: nil, class_name: "ScannedResource", file_filters: [], **attributes) |
There was a problem hiding this comment.
Can you describe how this is different than the IngestFolderJob?
app/services/dspace_ingester.rb
Outdated
| "DspaceResource" | ||
| end | ||
|
|
||
| IngestDspaceAssetJob.perform_now( |
There was a problem hiding this comment.
Any reason this is in the foreground?
app/services/dspace_ingester.rb
Outdated
| end | ||
|
|
||
| def dir_path | ||
| download_file_path = Rails.root.join("tmp") |
There was a problem hiding this comment.
Are we gonna run out of disk space doing this?
|
|
||
| require "io/console" | ||
|
|
||
| namespace :figgy do |
There was a problem hiding this comment.
What's all this for? Is this just for testing, or is ingest a two step process - get the token and pass it in? If it's two steps, can we fold that in?
| @@ -37,5 +37,19 @@ namespace :figgy do | |||
| ingester = JsonIngester.new(json_path: file_path, logger: @logger) | |||
| ingester.ingest! | |||
| end | |||
|
|
|||
| desc "Ingest a DSpace asset." | |||
There was a problem hiding this comment.
Are you planning to run like a bunch of these rake task, or is there a loop or something?
jrgriffiniii
force-pushed
the
jrgriffiniii-dspace-ingest-rake
branch
from
b9dc1ed to
796cf4a
Compare
jrgriffiniii
force-pushed
the
jrgriffiniii-dspace-ingest-rake
branch
4 times, most recently
from
5d8544c to
6122d93
Compare
…ake tasks, IngestDspaceAssetJob, DspaceIngester, DspaceCollectionIngester, DspaceCommunityIngester for importing DSpace resources over the REST API
jrgriffiniii
force-pushed
the
jrgriffiniii-dspace-ingest-rake
branch
from
1fd69e0 to
1ffa1c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This advances pulibrary/dspace-development#864