Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
Have you ran tests against this code?
This PR contains zero code changes.
Description of the Change
As referenced in #206 we discussed how to allow users to search tags of packages, including tags that exist only on this platform.
In my reply there I detail several steps that would be needed to begin to support this kind functionality.
With the first step possible being one that enables the generic searching of details within the
package.json
skeywords
array at all. Which is exactly what this PR does.Although unfortunately this PR doesn't support searching this field just yet, it will match with any exact matches just fine.
This new functionality is exposed via the query parameter
tags
on the following endpoints:/api/packages/search
/api/packages
This will allow exact matches to be found for any existing packages data in the
keywords
array from thepackage.json
. An example request would look like:https://web.pulsar-edit.dev/packages?tags=es6
https://web.pulsar-edit.dev/packages?tags=es6&q=language