r10k: Require 4.x & octokit: Allow newer versions & puppetlabs_spec_helper: Require 7.x #3249
Conversation
| @@ -60,15 +60,15 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "puppetfile-resolver", ">= 0.6.2", "< 1.0" | |||
| spec.add_dependency "puppet-resource_api", ">= 1.8.1" | |||
| spec.add_dependency "puppet-strings", ">= 2.3.0", "< 5.0" | |||
| spec.add_dependency "r10k", "~> 3.10" | |||
| spec.add_dependency "r10k", "~> 4.0" | |||
There was a problem hiding this comment.
We cant drop support for 3. We can update to support both 3 and 4 if that is helpful.
There was a problem hiding this comment.
Hi,
I took a bit of a break in responding here because the whole Ruby situation in the Puppet/Perforce tooling is a bit frustrating.
In theory we could do spec.add_dependency "r10k", ">= 3.10", "< 5". But bundler showed in the past that it had some trouble to figure out correct versions / it didn't always hounor the minimal ruby version in the dependencies. I don't know if this keeps working on ruby 2.5 / 2.6 if we do the change.
There was a problem hiding this comment.
spec.add_dependency "r10k", ">= 3.10", "< 5" seems reasonable to me
There was a problem hiding this comment.
But in order to actuallly use the new r10k version, we need a release of puppetlabs/orchestrator_client-ruby#38 .
|
@donoghuc why does bolt need to support Ruby 2.5? Why cant we drop it? |
The 7.0.0 release is broken, so we need to skip that.
This updates all version constraints for development dependencies in gemspec to allow their latest major versions. Followup for puppetlabs#3249
|
I think we can drop 2.5 for bolt 4. |
|
For bolt 4? Why can't we drop it now? Or do you mean for Bolt 3? |
|
The only reason we've kept 2.5 is for some internal testing on older OS. I was thinking of updating all that when we move to making the default ruby 3 based (keeping ruby 2.7 compatability for 2021.7 PE stream). What is the min version being 2.5 preventing for you now? |
This is a requirement to get newer dependencies for modules testing. pdk configures puppet_litmus, which in turn depends on bolt, which depends on outdated other gems.