Include systemd module for Amazon Linux 2023 #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjd1
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
bastelfreak
reviewed
Sep 3, 2024
manifests/default_mods.pp
Outdated
| @@ -16,7 +16,7 @@ | |||
| if $facts['os']['name'] != 'Amazon' and $use_systemd { | |||
| ::apache::mod { 'systemd': } | |||
| } | |||
| if ($facts['os']['name'] == 'Amazon' and $facts['os']['release']['full'] == '2') { | |||
| if ($facts['os']['name'] == 'Amazon' and $facts['os']['release']['major'] =~ /^(2|2023)$/) { | |||
There was a problem hiding this comment.
does it make more sense to always include it when systemd is the default init system?
There was a problem hiding this comment.
Yeah probably @bastelfreak
I think the original logic here was added to support AL1 & 2, with the former not using systemd. But since that's been EOL for a while now, the Amazon specific code shouldn't really be needed anymore.
There was a problem hiding this comment.
I went ahead and updated the PR.
ekohl
approved these changes
Sep 5, 2024
|
Can this get merged soon please? |
malikparvez
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include the systemd module for both AL2 and AL2023.
Additional Context
This resolves an issue where the service fails to start on AL2023.
Related Issues (if any)
#2561
Checklist
puppet apply)