Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set and run backups using another user via cron #1531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deepak7340
Copy link

No description provided.

@deepak7340 deepak7340 requested a review from a team as a code owner January 24, 2023 12:04
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Deepak Tiwari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
Copy link
Member

Functionality looks good on a first pass but would need some test's to back it up before we can merge it in.

@deepak7340
Copy link
Author

Hi @david22swan can you please merge this since we need to deploy this in our server.

@LukasAud
Copy link
Contributor

Hi @deepak7340, as @david22swan previously mentioned, the code looks good but we would need you to create some tests to back it up for the future. Additionally, it would be great if you could create a better description for the PR.

It also looks like there are some conflicts that must be resolved before CI can start running.

If you can address those few blockers, we would be happy to review/merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants