-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set and run backups using another user via cron #1531
base: main
Are you sure you want to change the base?
Conversation
Deepak Tiwari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
mysql::backup::mysqlbackup is a classthat may have no external impact to Forge modules. mysql::backup::mysqldump is a classthat may have no external impact to Forge modules. mysql::backup::xtrabackup is a classthat may have no external impact to Forge modules. mysql::params is a classBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 1 modules (near match):mysql::server::backup is a classBreaking changes to this file WILL impact these 4 modules (exact match):This module is declared in 140 of 580 indexed public
|
ada0345
to
3015b9a
Compare
Functionality looks good on a first pass but would need some test's to back it up before we can merge it in. |
96e3fa1
to
3015b9a
Compare
3015b9a
to
309de96
Compare
Hi @david22swan can you please merge this since we need to deploy this in our server. |
Hi @deepak7340, as @david22swan previously mentioned, the code looks good but we would need you to create some tests to back it up for the future. Additionally, it would be great if you could create a better description for the PR. It also looks like there are some conflicts that must be resolved before CI can start running. If you can address those few blockers, we would be happy to review/merge this. |
No description provided.