Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch tags to local, if different to remote #1371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmu-sprd
Copy link

We have the use case, that r10k is pulling modules from our own Git and some modules are applied via puppet apply based on a tag in the Git repository. Therefore it's needed, that the git tags are also updated in the deployed modules by r10k.

This PR adds updating the tags, when they differ local and remote.
This is running currently in our production and is working fine.

@tmu-sprd tmu-sprd requested a review from a team as a code owner January 24, 2024 08:36
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Mar 25, 2024
@tmu-sprd
Copy link
Author

Is there anything, I can do, to bring this forward?

@github-actions github-actions bot removed the stale label Mar 26, 2024
@tmu-sprd tmu-sprd requested a review from a team as a code owner April 9, 2024 06:39
@justinstoller
Copy link
Member

Sorry, I missed this.

The change looks good, but let me double check the prune => true behavior won't break any use cases.

Copy link

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 10, 2024
@tmu-sprd
Copy link
Author

I'm still interested to get this merged. Just commenting, to remove the stale label.

@github-actions github-actions bot removed the stale label Jul 12, 2024
Copy link

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 10, 2024
@tmu-sprd
Copy link
Author

Still interested.

Copy link

This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 10, 2024
@tmu-sprd
Copy link
Author

And again: Still interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants