598 tech add support for postgresql and pgsearch #613
Conversation
|
Hello @Robin481 We are currently a little stuck with the migration. Could you maybe have a look at the code to see, if it's going into the right direction? Thanks a lot! |
config/database.yml
Outdated
| @@ -6,16 +6,14 @@ | |||
| # PostgreSQL. Versions 8.2 and up are supported. | |||
| # | |||
| base: &generic | |||
| adapter: <%= ENV['RAILS_DB_ADAPTER'] || 'sqlite3' %> | |||
| adapter: sqlite3 | |||
There was a problem hiding this comment.
Why make sqlite3 the default here.
You want the opposite.
Either make PostgreSQL the default or leave it as it was and set the environment variable RAILS_DB_ADAPTER.
| @@ -1,28 +1,11 @@ | |||
| version: '2' | |||
|
|
|||
| services: | |||
There was a problem hiding this comment.
You can probably just delete the whole mysql service, or just leave it in but don't use it.
|
|
||
| services: | ||
| postgresql: | ||
| image: postgres |
There was a problem hiding this comment.
Looks good, (I haven't checked how much works and how much doesn't).
Is this a proper image reference or do you have to be more specific?
You then have to set the proper ENV variables so that Rails knows where to find the PostgreSQL container in the database.yml file. (you set the port number here so for example so you can just give rails that port number etc.)
There was a problem hiding this comment.
Also I would start by just making sure that the PostgreSQL container works.
- Start the postgresql container with docker and see if you have any errors starting.
- If it starts connect via
docker exec -it NAME_OF_CONTAINER bashand try to connect to the postgresql instance from there. - If you know that all works you can connect rails to the postgresql container and rails should then be able to create the database, migrate and see it (famous last words)
- To be even more thorough you can then connect to the postgresql container again and connect to the newly created database and see if the tables that rails just created are there and are functioning properly (they really should be there but I think this helps understanding 😁 )
db/schema.rb
Outdated
| @@ -98,4 +98,14 @@ | |||
| t.index ["default_ccli_user_id"], name: "index_users_on_default_ccli_user_id" | |||
| end | |||
|
|
|||
| create_table "versions", force: :cascade do |t| | |||
There was a problem hiding this comment.
I am not entirely sure why you have the versions table here.
Probably a left over from working on the other branches?
As you are basing this branch on master which currently doesn't have any versions this would probably break some stuff 😂 unless I am misunderstanding something 👼
There was a problem hiding this comment.
Whoops! yes this is a mistake 😆
mtnstar
force-pushed
the
598-TECH_add_support_for_postgresql_and_pgsearch
branch
from
1541656 to
8c5d897
Compare
mtnstar
force-pushed
the
master
branch
4 times, most recently
from
ecd3f3e to
d610931
Compare
No description provided.