Add askForColumns method #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay order and format for each one
|
Thanks for your PR. I will check this after my holiday. |
dmandrade
force-pushed
the
askForColumns
branch
from
59162e6 to
f3a79d4
Compare
dmandrade
force-pushed
the
askForColumns
branch
from
f3a79d4 to
dd25056
Compare
|
Hello, Would it be possible to merge this PR in the main branch ? I found this feature super useful ! Thank you ! |
|
@vincent-tarrit The PR was quite large and I started reviewing it some time ago. But I didn't find the time to do all the refactoring needed, yet. |
|
@pxlrbt I am building a new version of the software where I use this functionality and with that I will adapt the code to the current version of filament and filament-excel. I can do the pr when it is ready. Do you think it would be useful for the project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
askForColumns()method to let the user build a report. This is especially useful when you have a lot of columns and want to let the user pick the ones they need and customize the display order and format for each one.