Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VerticalGridTuple #56

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

malmans2
Copy link
Member

  • Passes pre-commit run --all-files
  • Project, label, and assignee tabs are populated

I recently discovered namedtuple, and I think we could make use of it in many places.
For example, accessing sigma on the t grid doing sigmas.t seems more robust (and readable?) than sigmas[0].

We could use it for pps as well (e.g., place all tanh2 parameters in a named tuple and access those like this pp_tanh2.a2).

@malmans2 malmans2 marked this pull request as draft July 16, 2021 16:35
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #56 (23787e2) into main (baeffab) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   94.07%   94.13%   +0.06%     
==========================================
  Files           5        5              
  Lines         287      290       +3     
==========================================
+ Hits          270      273       +3     
  Misses         17       17              
Flag Coverage Δ
unittests 94.13% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydomcfg/domzgr/zco.py 91.83% <100.00%> (ø)
pydomcfg/domzgr/zgr.py 100.00% <100.00%> (ø)
pydomcfg/utils.py 97.26% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baeffab...23787e2. Read the comment docs.

@oceandie
Copy link
Contributor

Defenitely more readable, I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants