Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using model_name and system model properties #865

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Using model_name and system model properties #865

merged 5 commits into from
Feb 6, 2025

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Feb 6, 2025 •
edited
Loading

Better aligns with information needed in https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-spans/

  • Removes name abstractmethod
  • Adds model_name property to correspond to genai.request.model - note, we pass this through to ModelResponse, which covers the genai.response.model case
  • Adds system property to correspond to genai.system
  • Unifies naming pattern for XModelName = Union[str, LatestXModelNames]

@github-actions github-actions bot temporarily deployed to deploy-preview February 6, 2025 20:49 Inactive
@sydney-runkle sydney-runkle merged commit 59cacf8 into main Feb 6, 2025
17 checks passed
@sydney-runkle sydney-runkle deleted the sem-convs branch February 6, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

@alexmojaki alexmojaki Awaiting requested review from alexmojaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-runkle @dmontagu