Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add macos arm64 wheels to release build #427

Closed
wants to merge 2 commits into from

Conversation

ales-erjavec
Copy link
Contributor

Add macos arm64 wheels to the release build.

@rdbisme
Copy link
Collaborator

rdbisme commented Jan 24, 2023

Hello @ales-erjavec. Did you test the build? Because I thought the build doesn't work on arm64. Last time I checked, there was not an easy way of testing it on Github actions. IF there is, first step would be to enable testing on it.

@rgommers
Copy link
Collaborator

I think this was automatically fixed because the wheel build job (https://github.com/pydata/bottleneck/blob/master/.github/workflows/ci.yml#L56) uses the defaults from cibuildwheel plus an os: matrix which contains macos-latest. When GitHub Actions moved to macOS 14 the runners changed to arm64, so now bottleneck has macosx-arm64 wheels on PyPI but no longer any x86-64 wheels. Maybe that's not too bad anymore, because arm64 Macs are 5 years old by now - most devs will be on arm64.

This PR can either be updated to add x86-64 on macos-13 runners (already deprecated though, GitHub Actions will drop them at some point) or closed.

@ales-erjavec
Copy link
Contributor Author

think this was automatically fixed because the wheel build job (https://github.com/pydata/bottleneck/blob/master/.github/workflows/ci.yml#L56)

True. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants