-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook for the pysnmp_mibs package #34
base: master
Are you sure you want to change the base?
Conversation
Hook for the package at https://pypi.org/project/pysnmp-mibs/
Added comment description
New edits for white space issues
@JoshDavisChem For the benefit of those of us who've never heard of this package or MIBs before (like me) could you give a brief overview of what the issue with this package is (without this hook). It appears to be pure Python which usually means no issues. I'm mostly interested in how these |
I should also say... thanks for working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual code looks good. Just need some explanation. Preferably in the comments of the hook file itself.
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-pysnmp_mibs.py
Outdated
Show resolved
Hide resolved
Adjust language for present tense. Co-authored-by: Brénainn Woodsend <[email protected]>
Co-authored-by: Brénainn Woodsend <[email protected]>
This is still on my radar. I just have to go back to my original program and other documentation to review my comments and make them more specific. |
OK, no rush - we're not going anywhere... |
Any update on this? |
Sorry, I have been busy and forgot. I am still working on it.
Thanks,
…On Fri, Jan 1, 2021, 1:54 AM Legorooj ***@***.***> wrote:
Any update on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMDAPGOGGQ5MQRV6BYVPR3SXVWTRANCNFSM4QDN4YRQ>
.
|
8003b05
to
df3371d
Compare
Hook for the pynsmp_mibs package at
https://pypi.org/project/pysnmp-mibs/
It is a package that contains a wide variety of MIB's precompiled for the pysnmp package