-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: update pydicom hook for compatibility with pydicom v3.0.0 #796
Conversation
Update the hidden imports for renamed and extended set of plugin modules, and collect the data files that are now required at run-time due to `pydicom.examples` being imported during `pydicom` module initialization.
f92b546
to
12e79e8
Compare
Works great for me, thanks! |
I think we're going to have to make a fuss upstream about those examples. It looks to me like they wouldn't exist at build time in a fresh (e.g. CI/CD) environment so the resultant application would have to redownload everything every time in onefile mode, be shot to pieces by the macOS sandbox and run afoul of permission errors if installed in a read only location. I'll have a proper look (and possible moan) tomorrow when I'm more awake. |
On linux, the downloaded files seem to go into |
I guess that's not quite so bad then. I raised pydicom/pydicom#2131 anyway. We'll see what they think. Is it worth putting an |
I don't think so - some of those files are part bundled with the package (and we collect those), while some of them are downloaded on first import (and we do not collect those, because they are not part of the package). |
I think we can get away without |
Ugh forget it. If I |
Hopefully that redundant |
Hmm, you might be right. Because they are not in the So the dictionary ends up like this (for frozen application with
|
Avoid collecting all data files from `test_files` directory, even the ones that are referenced `_DATASETS` dictionary that is constructed during initialization of `pydicom` module in v3.0.0. It seems that these files are not listed in `urls.json` so even if they are missing, not attempt is made to download them. If anyone requires these test files in their frozen application, they should explicitly collect the files themselves (same as with earlier versions of `pydicom`).
Meh, it's up to you. If pydicom/pydicom#2131 goes where I think it'll go then there's a good chance that we won't need any of them. |
Let's try getting away without collecting them, then. I've pushed a separate commit so that we have this documented in (the unlikely) event that we end up having to collect them after all. |
Update the hidden imports for renamed and extended set of plugin modules, and collect the data files that are now required at run-time due to
pydicom.examples
being imported duringpydicom
module initialization.Closes #795.