Add hook for saml2 #798
Merged
Add hook for saml2 #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfrydel
force-pushed
the
hook-for-saml2
branch
from
7410e70
to
0562cfb
Compare
rokm
reviewed
Sep 12, 2024
|
|
||
| # The library contains a bunch of XSD schemas that are loaded by the code: | ||
| # https://github.com/IdentityPython/pysaml2/blob/7cb4f09dce87a7e8098b9c7552ebab8bc77bc896 | ||
| # /src/saml2/xml/schema/__init__.py#L23 |
There was a problem hiding this comment.
Can we keep these URLs in single line? Even if it exceeds the nominal line length limit of 120 that we use, I think linter has enough decency to not make a fuss about it when it is a single "word".
There was a problem hiding this comment.
Of course. I added a commit with a fix. I was not sure if you prefer new commits or amending.
There was a problem hiding this comment.
I was not sure if you prefer new commits or amending.
For PRs like this, we usually end up squashing the commits into a single one during the merge. So either way is fine. (For larger changes that touch multiple places of the codebase, I prefer multiple atomic commits, which I think make the history easier to read).
rokm
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.