hooks: update gribapi hook for compatibility with eccodes v2.37.0 #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
hook-eccodes-2.37.0
branch
from
982b145
to
936afcf
Compare
|
And as usual, I am bitten by making the test a bit more thorough... |
Starting with `eccodes` v2.37.0, upstream provides binary wheels with bundled copy of the `eccodes` shared library. Adjust the hook for `gribapi` (part of `eccodes` dist) to account for that. Also handle the issue with circular imports by importing `eccodes` before `gribapi.bindings` when trying to obtain the path to the shared library.
rokm
force-pushed
the
hook-eccodes-2.37.0
branch
2 times, most recently
from
cac513f
to
eb27b5b
Compare
Add run-time hook for `findlibs` that overrides `findlibs.find()` function with custom implementation that gives precedence to searching `sys._MEIPASS` and then immediately falling back to `ctypes.util.find_library`. The original implementation searches a set of hard-coded paths before falling back to `ctypes.util.find_library`; those path include Homebrew directory on macOS, so if that happens to be installed on the run-time system, the original `findlibs.find()` implementation ends up returning system-wide copy of the library (if it is available) instead of the bundled one. Which, especially on macOS, can lead to problems due to (lack of proper) signature on the system-wide copy of the library when application itself is signed with developer identity. that searches a set of hard-coded paths before
bwoodsend
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
eccodesv2.37.0, upstream provides binary wheels with bundled copy of theeccodesshared library. Adjust the hook forgribapi(part ofeccodesdist) to account for that. Also handle the issue with circular imports by importingeccodesbeforegribapi.bindingswhen trying to obtain the path to the shared library.