Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] MWE for label_encode, factorize_columns, encode_categorical #1028

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

thatlittleboy
Copy link
Contributor

@thatlittleboy thatlittleboy commented Feb 23, 2022

PR Description

Please describe the changes proposed in the pull request:

  • Add MWE for the 3 functions mentioned in the title;
  • Add note of (deprecation) warning to the docs of label_encode.
  • Make factorize_columns non-mutating.

This PR is related to #972 .

(Let's review this after #1029 has been merged. I'll deal with any merge conflicts then.)
(encode_categorical MWE has been incorporated in #1029)

@ericmjl
Copy link
Member

ericmjl commented Feb 23, 2022

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1028 (4d6e45c) into dev (dced400) will increase coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1028      +/-   ##
==========================================
+ Coverage   96.95%   97.65%   +0.69%     
==========================================
  Files          77       77              
  Lines        2823     2852      +29     
==========================================
+ Hits         2737     2785      +48     
+ Misses         86       67      -19     

@thatlittleboy thatlittleboy self-assigned this Feb 26, 2022
@thatlittleboy thatlittleboy marked this pull request as ready for review March 1, 2022 11:05
@thatlittleboy thatlittleboy requested review from ericmjl and samukweku and removed request for ericmjl March 1, 2022 11:05
janitor/functions/factorize_columns.py Outdated Show resolved Hide resolved
@ericmjl
Copy link
Member

ericmjl commented Mar 2, 2022

@samukweku please do the honors when the checks are done! 🎉

@samukweku samukweku merged commit 92251b5 into dev Mar 2, 2022
@samukweku samukweku deleted the docs/mwe-sprint branch March 2, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants