[ENH] generic select function #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samukweku
requested review from
ericmjl,
nvamsikrishna05,
Zeroto521 and
thatlittleboy
|
🚀 Deployed on https://deploy-preview-1187--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1187 +/- ##
==========================================
+ Coverage 97.63% 97.72% +0.08%
==========================================
Files 76 76
Lines 3474 3514 +40
==========================================
+ Hits 3392 3434 +42
+ Misses 82 80 -2 |
ericmjl
approved these changes
Nov 1, 2022
|
Hi, I thought we could add some marks to notify users that |
|
The codecov is decreasing. |
|
Okie dokes, I think we should merge. The PR has been open long enough! |
samukweku
added a commit
that referenced
this pull request
Nov 28, 2022
* fix blank note output * return whatever user passes, even if they r duplicates * add DropLabel for dropping columns * generic select with tests * update test_select.py * update changelog * update docs in select * add version notifications * update docs for DropLabel class * update admonition * ensure booleans are converted into arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
select_rows,select_columnsThis PR resolves #1124 .
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.