[DEPR] deprecate pivot_wider
#1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samukweku
requested review from
ericmjl,
Zsailer,
zbarry,
sallyhong,
hectormz,
Zeroto521 and
thatlittleboy
|
🚀 Deployed on https://deploy-preview-1263--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1263 +/- ##
===========================================
+ Coverage 87.15% 97.51% +10.36%
===========================================
Files 78 78
Lines 3705 3702 -3
===========================================
+ Hits 3229 3610 +381
+ Misses 476 92 -384 |
samukweku
added a commit
that referenced
this pull request
Jun 1, 2023
* simplify logic * minor updates * changelog * fix userwarning on then function --------- Co-authored-by: Eric Ma <[email protected]>
ericmjl
added a commit
that referenced
this pull request
Jul 8, 2023
* skeleton * partial implementation * minor edits * add comments * fix notebook * Update conditional_join.ipynb * add changelog * updates * update changelog * add more tests * shortcut for monotonic increasing groups * use 0/1 for counter check for monotonicity * fix test failure * [DEPR] deprecate `pivot_wider` (#1263) * simplify logic * minor updates * changelog * fix userwarning on then function --------- Co-authored-by: Eric Ma <[email protected]> * fix range count * remove irrelevant imports * fix test fail * Update CHANGELOG.md * Update CHANGELOG.md * fix test failure * remove caching * add force parameter * update docstrings * fix failing test * remove strict eq join check --------- Co-authored-by: samuel.oranyeli <[email protected]> Co-authored-by: Eric Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
pivot_widerin favor of pandas pivotpivot_longerThis PR relates to #1045 .
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.